cal-itp / mobility-marketplace

A one-stop resource for modern, equitable and accessible public transit products and services.
https://www.camobilitymarketplace.org/
GNU Affero General Public License v3.0
5 stars 1 forks source link

Don't trigger empty PRs for Provider Map updates #553

Closed allejo closed 4 months ago

allejo commented 4 months ago

Add the pre-commit Action to our provider job so that the generated files are formatted in the same commit after it touches them. This will prevent future empty PRs from being created when the only diff is a newline due to formatting, and our pre-commit makes a second commit "undoing" the lack of a newline in the generated code.

I left a comment in my changes, but I want to point out that we need to allow the pre-commit step to continue despite failure because it will always fail whenever it formats files. We don't care about it "failing" since it'll have fixed our files already anyway.

Closes #550

netlify[bot] commented 4 months ago

Deploy Preview for cal-itp-mobility-marketplace ready!

Name Link
Latest commit ed254f838b57033da2455536ebda410cf91a6f66
Latest deploy log https://app.netlify.com/sites/cal-itp-mobility-marketplace/deploys/6636c5d37ccd4c00082a1f83
Deploy Preview https://deploy-preview-553--cal-itp-mobility-marketplace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.