Open BTollison opened 8 months ago
Some questions:/comments
service_id
in here? Are we assuming that because we only require start and endpoints that consumption might differ based on what the vehicle is doing in between those points?trip_id
instead of route_id
? We would expect there to be many trips for every one route, but we don't seem to have a way of distinguishing which trip we need to get the route from.trip_id
would also obviate the need for us to include direction_id
or service_id
route_id
is blank, then I think direction_id
must also be blankfrom
and to
, would it make more sense to get the stop sequence from the associated trip (via stop_times.txt
) instead of pulling stop_id
from stops.txt?I like this with one modification to support use cases beyond just BEBs: changing kwh_per_distance
to power_per_distance
and adding an optional foreign key to the Vehicle_type_id
(per #30) to distinguish charging for different vehicle types where applicable.
In an effort to make ODS more compatible with electric fleets, I am proposing the following addition of Energy_Consumption.txt
vehicle_type_id Reference ID to the proposed Vehicles.txt.
route_id Reference to route_id from routes.txt (but practically from trips.txt).
direction_id Reference to direction_id from trips.txt.
from Referencing either a stop_id or ops_location_id as a start point.
to Referencing either a stop_id or ops_location_id as an end point.
start_time This is the start of when these values are valid.
end_time This is the start of when these values are valid. When end_time is blank, start_time must also be blank.
kwh_per_distance Consumption per preferred distance unit (although I would really prefer that we force distance units to be described somewhere :) )
consumption_scenario enum value representing the state of the vehicle. This is mainly to distinguish between a stationary vehicle and one that is moving. This could also allow us to avoid having a stop_id and ops_location_id field for the "to" and "from" fields.
service_id Represents the service_id that these consumption values are valid for.