cal-itp / reports

GTFS data quality reports for California transit providers
https://reports.calitp.org
GNU Affero General Public License v3.0
6 stars 0 forks source link

Decide what to do on days with no files to check #62

Open machow opened 2 years ago

machow commented 2 years ago

Case 1: no files for a specific feed

On days where our files checks detect no files for a given feed, we currently do not show a blank column. For example, for itp id 294 in June, there should be a check on June 6th, but instead only 1 column is reported (June 20th).

image

This is because the itp id url error'd on June 6th (afaict a failure by the provider, since we have files for other feeds on that day).

Case 2: extractor failed

Another case of this occurs when the entire extraction script failed for a day being checked. This occurred on Sep 19th, so no reports have a Sep 19th column for file checks.

E.g. https://reports.calitp.org/gtfs_schedule/2021/09/10/index.html

To Decide

What should happen for the above cases? It seems like some options are...

evansiroky commented 2 years ago

Let's keep this issue open for now and proceed with omitting the columns for now. However, in a later effort, we'll completely close this out we should report information about where the error occurred (Cal-ITP error or publisher error).

edasmalchi commented 1 year ago

V2 warehouse will include a table pointing to where errors like this occur, after migrating reports we can either incorporate directly or leverage @owades checks