cal-smith / iitc-tweaks

Tweaks for IITC
http://iitc.reallyawesomedomain.com/
MIT License
16 stars 0 forks source link

Chat-toolbox nonstop fetches comm data at high zoom levels. #26

Open mxxcon opened 7 years ago

mxxcon commented 7 years ago

If I zoom out to a continent-level view, like z=5, for some reason this plugin causes my comm log to continuously keep fetching new data to the point where iitc becomes unresponsive. If I disable this plugin, things behave as expected. The only exclude filter I have is xmps\.biz|ingressfarm\.com|ingress-shop\.net|allforingress\.ecwid\.com|shop-ingress\.com|ingintems\.net

cal-smith commented 7 years ago

Odd, I can't reproduce that locally, maybe it's a conflict with another plugin?

mxxcon commented 7 years ago

Hmm. I tried disabling one of the plugins that I suspected could have interfered, but this plugin is still acting strange. For example https://www.ingress.com/intel?ll=39.656456,-73.87207&z=7 Initial load is fine. However if I vertically expand my chat window it seems to be loading a lot more messages than with this plugin disabled. After waiting a few moments for it to calm down, if I minimze chat window it starts loading a lot of new messages again and it keeps doing that for way longer than with this plugin disabled.

Also extras tab shows how many messages are loaded and how long it took for the last draw event. Once it loads over 400 messages, it takes over 1 second for each draw event and that makes iitc extremely slow.

Let me know if I can do something else to help troubleshoot this.

cal-smith commented 7 years ago

Interesting, I was sort of able to reproduce the issue ... naturally once you start excluding large quantities of messages (in this case, large quantities of spam) there will be an increase in load requests as iitc itself tries to populate the chat log ... I'll have to give this some thought, but it might be limited by the fact we have to do everything client side

Performance is something I have to work on... the biggest hit right now is probably regex creation, which I should be able to optimize

cal-smith commented 7 years ago

Also, if I could get your IITC version, browser and browser version, and (probably unnecessary) plugin version that would be handy

mxxcon commented 7 years ago

Windows 10, Chrome 56 (beta channel), iitc-test Version: 0.26.0.20170108.21815 (released yesterday). For plugins, you can message me on hangouts. My agent name is Mxx.