search

cal852 / COMP3111-Project

Web scraper for COMP3111
Do What The F*ck You Want To Public License
2 stars 0 forks source link

Questions about the webScrpper #12

Open enochwong3111 opened 5 years ago

enochwong3111 commented 5 years ago

  1. Can the scrapper get the data from two websites/sources now? since I see that you have separate (result)list and method to get the data, which may be easier for testing?

  2. I find that the 'date' data for Item grab from the "carousell.com" is something not actually a date (format), it returns xx days/months ago. Can it be more precisely like 13 Nov, etc.? If not, any things can do to fix it? Change the website, change the method to get the data or write a method to recognize it(less precise)?

  3. The currency exchange rate and method need to be discussed.

HYUNJS commented 5 years ago

1. Currently, there are two separate functions for each website. Both of them are working successfully in my laptop. However, when there are too much results for certain search word, the application freezes. I think this issue would be avoided by the assumption. I misunderstood the requirement for the result data. I will fix it now to return the merged data with correctly sorted.

2. I found that dcfever provides the posting date. If you guys wish to have a precise data for the posting date, I will change to that website. I was considering to change the Date type to String type. How do you guys think about this?

3. In terms of currency rate, the websites used at this moment only supports the price for HKD.

enochwong3111 commented 5 years ago

About the type of the 'date', do you mean that change its type in the table cell? or just in Item?