search

calabash / calabash-ios

Calabash for iOS
Other
1.81k stars 369 forks source link

Waiting until animation is finished before return from waiting steps #1305

Closed darvin closed 7 years ago

calabash-ci commented 7 years ago

Can one of the admins verify this patch?

msftclas commented 7 years ago

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. Thanks, Microsoft Pull Request Bot

jmoody commented 7 years ago

@darvin

Thanks for the change, but I have to reject it.

The problem is that wait_for_none_animating waits for all animations to complete. Imagine an app with a photo carousel - a new picture is animated on every 2 seconds - or an app with something that is constantly animating. wait_for_none_animating would timeout waiting for the animation to complete. Put another way, this change might break existing tests.

As an aside, we would like people to stop using predefined steps. In Calabash 2.0 our plan was to not include them.