calabash / calabash-ios

Calabash for iOS
Other
1.81k stars 369 forks source link

subviews of the main window should mask the views on the topmost controller #131

Closed jmoody closed 11 years ago

jmoody commented 11 years ago

https://groups.google.com/d/msg/calabash-ios/mzoYmdbRSmM/slq-YFiUlNMJ

to reproduce:

clone the demonstration project, build, and install the gems
  1. git clone git@github.com:jmoody/briar-ios-example.git
  2. cd briar-ios-example
  3. open the briar-ios-example workspace in Xcode
  4. build the Briar-cal target for any simulator (any iOS and any device)
  5. cd briar-ios-example/Briar/features
  6. bundle update && bundle install
    run the cucumber steps to reproduce the problem

there is cucumber.yml file in the briar-ios-example/Briar directory with several profiles.

there is a RubyMine .idea directory in the briar-ios-example/Briar/features directory which might be of interest. there are several shared build configurations.

expected: that when a subview on the main window cover the topmost controller, then the tab bar, nav bar, and subviews of the topmost controller would be hidden found: i can still query these views

krukow commented 11 years ago

That's fine. Thanks

On Wednesday, April 10, 2013, Joshua Moody wrote:

https://groups.google.com/d/msg/calabash-ios/mzoYmdbRSmM/slq-YFiUlNMJ

sample project in-progress.

@krukow https://github.com/krukow i would like to use the briar-ios-example like i did for

128 https://github.com/calabash/calabash-ios/issues/128

but, i want to make sure that this is easy for you.

— Reply to this email directly or view it on GitHubhttps://github.com/calabash/calabash-ios/issues/131 .

krukow commented 11 years ago

Thanks for the excellent bug report. I'm just curious - this is not a regression, right? We just haven't seen this issue before?

jmoody commented 11 years ago

i have never seen this particular issue before, but i never tried to anything like this before so i can't say whether or not this a problem that was introduced recently.

krukow commented 11 years ago

I've released a 'pre-release' gem which fixes this issue by improving the visibility heuristic: calabash-cucumber-0.9.145.pre1.gem.

I've tested this version myself and it didn't impact my test suites negatively.

Could you please give this version an extensive test and let me know if you find any bugs.

krukow commented 11 years ago

Joshua, did you find something here, or can we release?

jmoody commented 11 years ago

hi karl,

the pre-release did not fix the problem.

 Background:  a subview on the main window that hides the topmost controller completely
    When I add a security veil to the main window

  Scenario: the navbar is hidden but query can still find it
    Then I should not be able to see navigation bar because of the security veil
     ==>   waited for '2.0' seconds for 'navigation bar' to disappear but it is still visible 
    Then I dismiss the security veil

  Scenario: the tabbar is hidden but query can still find it
    Then I should not be able to see tab bar because of the security veil
   ==>  waited for '2.0' seconds for 'tab bar' to disappear but it is still visible
    Then I dismiss the security veil

  Scenario: the topmost view is hidden but query can still find the buttons
    Then I should not be able to see the elements on the topmost view
    ==> waited for '2.0' seconds for '["show modal", "email", "show sheet", "first"]' to 

disappear but some of  them are still visible 
    Then I dismiss the security veil

2013-05-20_22-41-51

krukow commented 11 years ago

Are you sure you're running the latest pre-release on both server and client? I tested with your app when I did this fix, so it should work. If not, please make a console session to demo it! Thanks!

jmoody commented 11 years ago

the server had not been updated. fixed. 2013-05-21_11-01-42