search

calabash / calabash-ios

Calabash for iOS
Other
1.81k stars 369 forks source link

Release/0.21.6 #1389

Closed AlexWellsHS closed 6 years ago

AlexWellsHS commented 6 years ago

0.21.6

TODO

jmoody commented 6 years ago

Jenkins test this please

jmoody commented 6 years ago

@AlexWellsHS

Update the run_loop dependency version:

https://github.com/calabash/calabash-ios/blob/develop/calabash-cucumber/calabash-cucumber.gemspec#L62

s.add_dependency("run_loop", ">= 3.0", "< 4.0")

I think you will then see which rspec tests are failing.

All references to RunLoop::SimControl can be replaced with some other RunLoop method.

If you have any questions, just ask here or in Gitter.

AlexWellsHS commented 6 years ago

@jmoody not sure about commit f72a770. running rbenv exec bundle exec rspec spec/lib spec/bin spec/integration passes every test besides calabash_sim_accessibility. any advice would be much appreciated.

jmoody commented 6 years ago

def calabash_sim_accessibility detect_accessibility_support

Delete these methods and any callers.

There are no replacements and enabling accessibility is no longer necessary.

As you have noticed, the CLI is not a good shape.

AlexWellsHS commented 6 years ago

@jmoody all tests passing. am i able to kick off jenkins myself?

AlexWellsHS commented 6 years ago

Jenkins test this please

jmoody commented 6 years ago

@AlexWellsHS

The Jenkins tests have not run automatically because of some permissions problems.

The "green check box" indicates that you have signed the MSFT OSS agreement.

I have added you as a contributor. You will need to accept the invitation. This should allow Jenkins to run the tests automatically.

AlexWellsHS commented 6 years ago

@jmoody shall i follow the Release Docs from here?

jmoody commented 6 years ago

@AlexWellsHS Those docs look out of date. I will handle from here.

jmoody commented 6 years ago

@AlexWellsHS Looking at this again, you need to do the merge from your fork AlexWellsHS:release/0.21.6 back into calabash:develop. I think you have permission to do this.

Now that you are a maintainer, it will be easier for you to work from the calabash/calabash-ios project (not from your fork).

AlexWellsHS commented 6 years ago

@jmoody cant i just make a PR from master to develop since this was merged into master? also, you told me to remind you to update the readme.md after the release.

jmoody commented 6 years ago

You must merge release/0.21.6 into develop.

remind me

Thanks!