search

calabash / x-platform-example

Example of cross-platform BDD with Cucumber and Calabash
90 stars 60 forks source link

Updated framework with new apps and stories #11

Closed gunesmes closed 5 years ago

gunesmes commented 5 years ago

@krukow I have updated the framework with new apps, the wordpress app doesn't work. I allso added converter.sh to convert the project to generic Calabash project to submit it Amazon device farm. Maybe some users use this for Amazon.

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

gunesmes commented 5 years ago

@jmoody thanks for your comments, I have updated the pr respect to your comments. Could you please review this?

jmoody commented 5 years ago

@gunesmes I really don't have the time. Are you on Gitter? Maybe we can ask someone there to review and merge.

gunesmes commented 5 years ago

@JoeSSS I have updated the project, could you please review it?

JoeSSS commented 5 years ago

@jmoody I do not have right for this repo

JoeSSS commented 5 years ago

@gunesmes now I can merge your PR, after you address last two issues + give a 👍 for that the steps with Timeout actually do not crash because 'timeout' is not required.

gunesmes commented 5 years ago

@JoeSSS I updated. it is not necessary to require timeout when run and console.

JoeSSS commented 5 years ago

@gunesmes Thanks!