calagator / calagator.org

Rails shell for Portland's calendar aggregator
12 stars 13 forks source link

Improve required field indicators for screen reader users on "Add an Event" form #30

Closed carrythebanner closed 2 years ago

carrythebanner commented 4 years ago

On the "Add an Event" form, a required field is rendered like this: <li class="string input required autofocus stringish" id="event_title_input"> <label for="event_title" class="label">Event Name<abbr title="required">*</abbr></label> <input maxlength="255" id="event_title" autofocus="autofocus" type="text" name="event[title]"> </li>

This mostly works well, but screen reader users will hear something like "Event Name star" as the name of the field ("star" being the asterisk, as VoiceOver on macOS announces it). Additionally, the field isn't indicated as required to a screen reader.

These can be fixed by:

With both of the above, screen reader users will hear something like "Event Name, required, edit text" when the input is focused.

evolve2k commented 2 years ago

Seems to have been fixed and even merged. Recommend Close.

carrythebanner commented 2 years ago

Aye, fixed with https://github.com/calagator/calagator/pull/598, closing this issue.