calamares / calamares-extensions

Examples of Calamares branding
36 stars 19 forks source link

[mobile] Allow distributions to configure expected wait time #10

Closed Undef-a closed 3 years ago

Undef-a commented 3 years ago

On Mobian, the installer takes far longer than 20 seconds to conduct this phase of the install. This allows changing the wait time displayed to the user in order to avoid them restarting, which may cause the installer to fail on the second attempt.

ollieparanoid commented 3 years ago

I've missed this before, but the new option needs to be documented in mobile.conf:

https://github.com/calamares/calamares-extensions/blob/calamares/modules/mobile/mobile.conf

Since it's about how long the commands will take, I think the "Commands running in the installer OS" section is fitting.

Other than that, it looks good.

(Btw, thanks for updating your other PR too! I'm a bit busy right now, but I'll try to do another review over the next days.)

ollieparanoid commented 3 years ago

LGTM!

@adriaandegroot: can you take a look at it / merge it?

adriaandegroot commented 3 years ago

There's some peculiar issues with the string, but if translation isn't a concern then this LGTM -- @ollieparanoid ?

ollieparanoid commented 3 years ago

Hm, good point with translations.

The more I think about this patch, the less I'm convinced it is a good idea. The screen that displays the wait time is needed in the first place, because of the hack that makes the partition job run early (reasoning for that is described here). Extending that with a config option that can't be translated just adds to the technical debt.

The mobian distribution needs this patch to have it say "up to two minutes" instead of "up to 20 seconds". So let's simply make it always say "up to two minutes" instead of adding the config option. It's not wrong, even if it goes faster (in QEMU it's done in about one second actually):

=> https://github.com/calamares/calamares-extensions/pull/11

Sorry for not realizing this earlier, thanks for your efforts @Undef-a and @adriaandegroot!

Undef-a commented 3 years ago

This looks like a much simpler method.