calamares / calamares-extensions

Examples of Calamares branding
36 stars 19 forks source link

WIP: Configuring SSD #18

Closed abalfoort closed 1 year ago

abalfoort commented 2 years ago

Module to configure SSD: ssdcfg.

This is a work in progress. So, I need some feedback on this. Especially how to make this work on all distro flavors.

This module enables fstrim, configures swappiness and sets the IO scheduler.

FIXES #1987

kkofler commented 2 years ago

The backend setting in the .conf file is bogus (copied from packages, where it makes sense; here, it does not).

abalfoort commented 2 years ago

Indeed, this is currently not used. I'm still looking for a way to install sysfsutils if needed.

I have no way of adding sysfsutils to the list of packages to be installed by the packages module.

adriaandegroot commented 1 year ago

The config file and schema seem to be mismatched; what is all that packaging setting doing there? The schema mentions grubcfg. Does is validate the current config file? Because vm.something looks like a dubious key to me.

adriaandegroot commented 1 year ago

You can manipulate the packages-to-install: it's just a GS object, so you can treat it like a dict in Python. But it will be messy and unpleasant. More effective would be two issues / PRs against Calamares itself:

abalfoort commented 1 year ago

Thanks. My C++ knowledge is limited but I'll take a look at it after the holidays.