Closed nmschulte closed 1 year ago
Overall this looks reasonable, but I'd like to test it out. My two main worries here are:
/home/mobian
. I'm not sure whether those are there even on an unused install but if they are they might cause problems.I'll get back when I've tested these two. Thanks for fixing this one!
- I'm not sure whether those are there even on an unused install but if they are they might cause problems.
I looked at this; the current mobian-pinephonepro-phosh-20230606.img
e.g. does not contain any references to the mobian
user in /home/mobian
.
Could I ask that you please build and run your commits? I just built it and the install fails because it's trying to change the user's password before creating that user.
The height of the page might be too big for the Librem5
Just tested it, this isn't an issue.
@Undef-a, @adriaandegroot -- I have confirmed that these changes resolve #25, completing the desires of #22.
In Mobian, where I tested, the user's full-name is still "mobian" I believe; I don't know if this is behavior of Mobian or of the mobile module: if the latter, this could be updated to change the full-name to match the given username.
As noted above, the new cmdUsermod
will need to match any change to username
config, otherwise an error like this will present:
Just got the chance to test this. It's working pretty much as expected now.
As for the fullname, chfn
seems to be the command you want, although according to the man page and some research usermod -c <new name>
might do the same. If chfn
is run after the username change it shouldn't require a configurable command as it should only need the new username.
Thanks for fixing this one up! It's very nearly there.
With that last commit LGTM. After install I have a newly named user with no sight of "Mobian" anywhere. Thanks. @adriaandegroot unless @ollieparanoid or @PureTryOut think these commands will cause issues on pmOS I'd say this one is good to go.
We need to make sure shadow
is installed, but otherwise this will not cause us problems. Go ahead 👍
Thank you. Sorry for the break.
I've just verified that this also fixes the bug on postmarketOS, and creating the user with a custom username works. Thanks for fixing it @nmschulte!
@adriaandegroot: can you please tag a fixup release?
attempts to fix #25