search

calamares / calamares-manjaro

Manjaro specific modules for Calamares
GNU General Public License v3.0
18 stars 10 forks source link

track system config stuff #22

Open udeved opened 8 years ago

udeved commented 8 years ago

keep track on stuff to do after moving config to livecd for iso

udeved commented 8 years ago

Would be very nice if upstream implemented writing displaymanagers to globalstorage.

Right before last line's return in displaymanager main.py:

libcalamares.globalstorage.insert("displayManagers", displaymanagers)

I made it so that postcfg makes use of displayManagers, so manjaro doesn't have to deploy its own displaymanager module @philmmanjaro @teo .

philmmanjaro commented 8 years ago

Fork the calamares repo, create a new branch if needed and modify the modules as you may think fit. Then request a normal pull so we can review your work upstream.

udeved commented 8 years ago

I have pushed both in calamares-manjaro. However, just this one line should go upstream and we drop our displaymanager. ;)

philmmanjaro commented 8 years ago

You have to create a pull request in calamares repo and not add a custom module to calamares-manjaro repo. I can review your work and create that pull request myself if needed. This however later, maybe tomorrow.

udeved commented 8 years ago

I can do PR for this one line upstream change, no problem. Once its merged, we drop the custom displaymanager module.

udeved commented 8 years ago

https://github.com/calamares/calamares/pull/251

@philmmanjaro

I took out keyboard.conf writing in postcfg, I think its useless.