search

calamares / calamares-manjaro

Manjaro specific modules for Calamares
GNU General Public License v3.0
18 stars 10 forks source link

Replacement of hardwarecfg with mhwdcfg #24

Open philmmanjaro opened 8 years ago

philmmanjaro commented 8 years ago

Before we replace hardwarecfg we have to review the new code of mhwdcfg and think on how we handle following things:

udeved commented 8 years ago

Right, mhwdcfg work if local is true, ie install from mounted mhwd repo in chroot. I am currently fixing mhwdcfg if local false, ie online packages, tricky if chrootcfg is used, currently also addressing it. Either networkcfg module doesn't properly work, or the africa mirror is absolutely out of sync and terrible.

Btw, virtualbox drivers, shouldn't be necessary to remove them, since no present in root or DE image.

philmmanjaro commented 8 years ago

Well, for the network thing with the mirrors we should deal with it properly by configuring the mirrors by country. Checkout the new code of locales module. Teo added some geoip detection code to it. Anyway, that selection of country should be used to generate the mirrorlist. If the country is not found as we might have no mirror for it yet, we should autoconfig the mirrorlist.

udeved commented 8 years ago

I had the same idea in mind, to use lang selection to match mirror location. For the moment, ranking code is in chrootcfg, but we could start a manjaro specific code module that deals with mirrors. However, such module would ideally have a branch selector.

udeved commented 8 years ago

@philmmanjaro

I merged latest changes and fixes mhwdcfg is now ready for testing

One thing, if mhwd is configured for local repo, and netinstall only installs base group, or unpackfs only extracts root-image, mhwd fails, since not all required packages are in the local mhwd repo.

philmmanjaro commented 8 years ago

Well, we have to see about that. Currently building some kernels ...

udeved commented 8 years ago

I am about to upload cal-dev so we can test it all. Regarding mhwd repo, its basically more a netinstall issue, since I can't add logic to select or deselect particular groups, if some other group is selected

philmmanjaro commented 8 years ago

Ping me if mt-0.13.4 is ready to be released ...

udeved commented 8 years ago

Should be today or tomorrow, but my previous tests were all fine. I guess we can do it today.

udeved commented 8 years ago

I don't think we need pulse and alsa stuff. It all works fine in live session without it so far.

We don't need to remove vbox driver, since there is none installed in target root.

philmmanjaro commented 8 years ago

Right, however let me double check that with the virtualbox drivers.

udeved commented 8 years ago

We run mhwd in chroot, and image is clean.

philmmanjaro commented 8 years ago

Ok, lets try it then with the next calamares-dev build ...

udeved commented 8 years ago

mt-0.13.4 already use it.

philmmanjaro commented 8 years ago

Well, calamares package don't ship mhwdcfg module at all. So we have to test it first and add it later to the stable package when ready.

udeved commented 8 years ago

I have set cal-dev in profiles for now.

philmmanjaro commented 8 years ago

I assume in master branch. I'm aiming for the 16.08-preX branch which is still based on mt-0.12.x series. However go on with your development.

udeved commented 8 years ago

just saying, shared packages-live has cal-dev set. So temporarily override it, or else we get tons of complaints from team that cal doesn't work. ;)

philmmanjaro commented 8 years ago

Sure. Works for me as long as these packages stay in unstable for now. It is great that the team is working so hard to finally getting netinstall working. Was needed for a long time.

udeved commented 8 years ago

We only need to establish how we deal with the netgroups, per profile?, one fits all?, should we have a yaml repo? Could netinstall module accept local yaml netgroups...? Tons of questions. :) Online netgroups is cool however, you can test them in one running session.

philmmanjaro commented 8 years ago

After I found some time to test the new calamares package, I might also find some time to remove hardwarecfg in calamares-dev and test it also. Good work on the module!

udeved commented 8 years ago

We need to properly test chrootcfg(for net boot strap), mhwdcfg, servicescfg(openrc), But they should all work.

philmmanjaro commented 8 years ago

Sure, but lets do it one by one and first with regular installation procedure, which is using unsquash.

udeved commented 8 years ago

This one worked in quite a few test installs. ;)

philmmanjaro commented 8 years ago

Can someone point me to the exact commit so I can review these changes? I assume we are all talking about this now:

To automatically set QT_QPA_PLATFORMTHEME for user session, add the following line to ~/.profile:

[ "$XDG_CURRENT_DESKTOP" = "KDE" ] || [ "$XDG_CURRENT_DESKTOP" = "GNOME" ] || export QT_QPA_PLATFORMTHEME="qt5ct"
philmmanjaro commented 8 years ago

We also have to check on how we fix it for root account, as Manjaro-Settings-Manager has theme issues using pkgexec otherwise. kdesu and sudo -E seems to use the user session settings just fine.