search

calamares / calamares-manjaro

Manjaro specific modules for Calamares
GNU General Public License v3.0
18 stars 10 forks source link

postcfg - we should find a way to configure root account also #27

Closed philmmanjaro closed 8 years ago

philmmanjaro commented 8 years ago

We need something similar for:

    # Configure root user
    cp /etc/skel/.{bash_profile,bashrc,bash_logout,extend.bashrc} /root/
    if [[ -d /etc/skel/.config ]];then
        cp -a /etc/skel/.config /root/
    fi
udeved commented 8 years ago

Not sure, but how do other distros configure /root? In my opinion, besides bash stuff, we shouldn't copy .config After all. it is root account, gui apps shouldn't be run as root, and user should be reminded of that, a bad ugly theme is ideal for as reminder. :)

udeved commented 8 years ago

@guinux

I see one slight "problem" with the mirror addition. If we deploy a pure offline iso, the ranking fails. Perhaps we add a check, if globalstorage hasInternet...

philmmanjaro commented 8 years ago

@udeved: I don't get the combination of the commit Guillaume did and the question on how to configure the root account ...

philmmanjaro commented 8 years ago

https://github.com/calamares/calamares-manjaro/commit/0ef92374dd45321292d2d5dc0985d669cfda519e

udeved commented 8 years ago

Well, you talk root account, I talk mirror PR. :)

I think its bad practise to configure apps in root account, and potential security risk.

udeved commented 8 years ago

I see, oops, I read postcfg in title and confused it with the other one where you talked root account too. :)

philmmanjaro commented 8 years ago

https://github.com/calamares/calamares-manjaro/commit/ae2a312fba87a35d68a6ad6ea0d8be769d6b04f2