calamares / calamares-manjaro

Manjaro specific modules for Calamares
GNU General Public License v3.0
18 stars 10 forks source link

[GRUB cfg] Wrong LUKS id written for /swap partition to resume hibernation #39

Open tabroughton opened 4 years ago

tabroughton commented 4 years ago

Being as there are a few reports of this issue on Manjaro KDE installation maybe the bug ought to be raised here in the Manjaro Calamares repo.

If anyone is triaging please could you decided if this is a manjaro specific issue. If not then the manjaro team might want to chase in core.

The issue is here calamares 1208 . On an install which creates a LUKS /swap partition for encrypted hibernation the root LUKS UUID is written to the grub.cfg as the resume UUID instead of the swap partition UUID.

I notice that there is also grub.cfg writing source code in this manjaro repo, last commit 3 years ago whereas the core calamares grub.cfg source last commit was only a few days ago, does this version need to pull from upstream or merge in changes for swap UUID? It does look like there are quite a few changes in the code to deal with it in core.