search

calamares / calamares

Distribution-independent installer framework
https://calamares.io
1.33k stars 388 forks source link

Creating LVs without a name causes installation to fail #1135

Open abucodonosor opened 5 years ago

abucodonosor commented 5 years ago

Describe the bug

Creating LVs from calamare without to set 'LVM Lv name' will break on create this partition.

Testing done in a VirtalBox 64bit VM.

( Kpmcore 3.3.0 , Calamares 3.2.{4,5,6} )

To Reproduce Steps to reproduce the behavior:

  1. Boot a VM with 2 HDDs

  2. Prepare HDDs like this : .. Open an terminal

    for each HDD do:
fdisk /dev/sdX
type : n , p, enter , enter , enter , t ,8e , w

pvcreate /dev/sda1 /dev/sdb1
vgcreate calatest /dev/sda1 /dev/sdb1
  3. Start calamares
  4. On Partitioning site: Click Manual partitioning Create LVs without to set an Lv name Start the installtion and see this error :

empty-lv-name

That means Lv names cannot be optional right now as long calamares itself does not append some name when empty.

stikonas commented 5 years ago

Calamares should use QRegularExpressionValidator like partition manager does in src/gui/gui/volumegroupdialog.cpp. Although, it might be better to move actual QRegularExpression into kpmcore to share code...