search

calamares / calamares

Distribution-independent installer framework
https://calamares.io
1.37k stars 395 forks source link

enhancement: change grub destination according to insall location/device #2245

Open g6094199 opened 11 months ago

g6094199 commented 11 months ago

hi,

while installing on systems with more than one block device you need to select to install destination for debian. When changed from the by default chosen device to another it would be VERY handy that the grub install destination would also switch to the choosed device, cause in most cases the chosen device should hold grub, too.

i attached a hdd via dock to a laptop and booted the installer via usb stick. spiral should be installed to the dock located hdd. in a hurry i forgot to change to grub location an grilled my windows bootloader on the laptops internal drive, cause this was the default location while drive detection in calamares. this was anoying but not to terrible to fix. but just a waste of time. ;-)

https://github.com/SpiralLinux/SpiralLinux-project/issues/343

dalto8 commented 11 months ago

The problem is that there is no way to know what the intention of the user is in this case.

I would argue that most of the time the correct behavior is to use the current EFI partition by default, not to create a new one on the target drive.

In your case, that wasn't true because you were installing to a device you wanted to be independent.