Gate Turn Continuity - Githubissues

calband / calchart-redesign

Calchart 4 for the web! 🌐

https://calband.github.io/calchart-redesign/

4 stars 0 forks source link

Gate Turn Continuity #115

Closed adhamrait closed 3 years ago

adhamrait commented 3 years ago

Description

Fixes issue #23

Adds the Gate Turn continuity, with unit tests for the editor and the continuity itself.

The continuity editor looks like that, with a little button for choosing the center of the gate turn

Still to do:

Making the center button work!
Multiple centers so that if there are many gate turns happening at the same time there doesn't need to be a separate dot type for each gate turn

Pre-PR checklist

[x] Ran npm run serve and:
- [x] Checked basic functionality
- [x] Checked that errors are handled
[x] Ran npm run lint
[x] Ran npm run test:unit
[x] Ran npm run test:e2e and ran relevant tests
[x] Attached reviewers to PR and pinged on Slack/email

vhlee7 commented 3 years ago

keep center point implementation search through map to find center point center point has array of dot ids, center point is mapnumber to space flows: without center point

action items: