calband / calchart-redesign

Calchart 4 for the web! 🌐
https://calband.github.io/calchart-redesign/
4 stars 0 forks source link

Dot at event #142

Closed vhlee7 closed 3 years ago

vhlee7 commented 3 years ago

Description

Fixes issue #126

findDotAtEvent now finds position of dot at specific beats of a stuntsheet. I added a beat variable and the function checks for the dot's position at that beat.

There is an issue that came up where sometimes the mouse is not able to click/find the dot. To replicate, increment and decrement the beats and sometimes you will be unable to click on a dot.

Pre-PR checklist

Screenshots/GIFs

[Attach screenshots if making a visible change!]

rmpowell77 commented 3 years ago

it might be nice to have a unit test for this.

adhamrait commented 3 years ago

I'm still getting an issue with the lasso tool:

ezgif-3-ce5d6446d20b

I think this can be fixed at line 92 of ToolSelectMove

vhlee7 commented 3 years ago

Thank you for all the feedback!

vhlee7 commented 3 years ago

can merge, make another pr for unit tests fix to dot repositioning issue: can't move dots when not on hup beat