Upload E2E videos on success and failure, cache npm - Githubissues

calband / calchart-redesign

Calchart 4 for the web! 🌐

https://calband.github.io/calchart-redesign/

4 stars 0 forks source link

Upload E2E videos on success and failure, cache npm #156

Closed MichaelTamaki closed 3 years ago

MichaelTamaki commented 3 years ago

Description

Fixes issue #155

Upload E2E videos on success and failure

Cache some NPM files as long as package-lock.json stays the same. See https://github.com/actions/cache/blob/main/examples.md#node---npm

Pre-PR checklist

[ ] Ran npm run serve and:
- [ ] Checked basic functionality
- [ ] Checked that errors are handled
[ ] Ran npm run lint
[ ] Ran npm run test:unit
[ ] Ran npm run test:e2e and ran relevant tests
[ ] Attached reviewers to PR and pinged on Slack/email

Screenshots/GIFs

[Attach screenshots if making a visible change!]

vhlee7 commented 3 years ago

just needs approval npm install easy cache increases speed by 20 sec