calband / calchart-redesign

Calchart 4 for the web! 🌐
https://calband.github.io/calchart-redesign/
4 stars 0 forks source link

Warning System #161

Closed adhamrait closed 3 years ago

adhamrait commented 3 years ago

Description

Fixes issue #158 #159

Implements a warning system for errors that the user creates! Also, clicking on warnings will send the user to their location for easier fixing.

Still need to add unit/e2e tests for everything...

Pre-PR checklist

Screenshots/GIFs

The warning pane is below the tool box/menu-bottom.

image

The warning pane includes a warning's name, its description, and hovering over shows its location. Clicking on the warning will send the user to the proper stunt sheet and select any dots that the warning involves.

image

The warning pane can also be filtered to only show warnings for the current stuntsheet.

image

Stuntsheets with errors have icons in MenuLeft

image

Major errors show up in red...

image

Demo in slack!

adhamrait commented 3 years ago

Add checks throughout flows for overlapping

vhlee7 commented 3 years ago

Meeting notes: Demo?

warning1: stuntsheet different number of dots warning2: dots overlapping warning3: unnamed stuntsheet/dot warning4: stuntsheet w/ no dots errors in red: stuff that needs to be fixed errors not in red: stuff that does not need to be fixed

Stuff to work on: click on warning selects correct dots fix error naming - change error to issue *performance - iterate twice to find overlapping dots

new issue: new unit test for shows