This PR adds a new dropdown to the top menu, Grid, which allows the user to change the grid size. However, there are some issues I would like to address, both on my end and in general.
Addresses issue #62
Problems
I have not yet changed the coordinate rounding function. Could someone tells me where it is called so I can figure out how best to change it?
The old logic for horizontal grid generation explicitly avoided generating grid lines on yard lines unless the yard lines were removed. However, to make it easier to extend to 1-step and 4-step grids, I changed the logic to resemble the vertical lines, and therefore redundantly generates grid lines on top of yardlines. Should we strive to keep gridline generation non-redundant, or would it be easier in the long run to keep it as I have it? For reference, the old X-Offset function is present, but commented out.
Due to the dimensions of the field, the 4 Step grid leaves a small horizontal space at the bottom of the field. Should we keep 4 Step grid generation as is, or should we change it somehow?
Pre-PR checklist
[x] Ran npm run serve and:
[x] Checked basic functionality
[x] Checked that errors are handled
[x] Ran npm run lint
[x] Ran npm run test:unit
[ ] Ran npm run test:e2e and ran relevant tests
[x] Attached reviewers to PR and pinged on Slack/email
Description
This PR adds a new dropdown to the top menu, Grid, which allows the user to change the grid size. However, there are some issues I would like to address, both on my end and in general.
Addresses issue #62
Problems
Pre-PR checklist
npm run serveand:npm run lintnpm run test:unitnpm run test:e2eand ran relevant testsScreenshots/GIFs