search

calband / calchart-viewer

An online show viewer and continuity generator for Calchart.
calband.github.io/calchart-viewer/
2 stars 2 forks source link

Generate Blank PDF #101

Closed brandonchinn178 closed 10 years ago

brandonchinn178 commented 10 years ago

This may be difficult.

brandonchinn178 commented 10 years ago

If you look at the PDF branch, I added a pdf directory to the js directory, which will contain all of the pdf-generating files. We can split up the files according to like a header script, a continuity script, an overall field script, etc. so we don't have to have all of the scripts in one file... too spread out?

noahsark769 commented 10 years ago

Hm, it depends on how much code there will actually be to generate this pdf: my guess is actually probably not too much (maybe 500-600 lines of actually doing stuff). I think we can split it up into separate files for now (just like, each file defines a function which takes in a PDFGenerator object or something and draws the relevant things in the right places). It might make more sense when this is actually done to put everything into one file, but for development in parallel separate files should be a bit better.

brandonchinn178 commented 10 years ago

Completed in commit 55a7fbcb3340fe094eac735b7913d0212c7d66a6

I'm thinking we shouldn't pull request until we're completely done?

noahsark769 commented 10 years ago

@brandonchinn178 let's open pull requests to merge changes into the PDF branch (you can do that with github). I promise I'll actually merge them! Also I'm gunna sign off #110 soon haha

brandonchinn178 commented 10 years ago

:+1: you mean make more branches to merge into the PDF branch?

noahsark769 commented 10 years ago

Yup