search

calband / calchart-viewer

An online show viewer and continuity generator for Calchart.
calband.github.io/calchart-viewer/
2 stars 2 forks source link

Implement Individual Continuity #104

Closed brandonchinn178 closed 10 years ago

brandonchinn178 commented 10 years ago

Includes:

  1. Movements
  2. Total beats
  3. Border between general movements, e.g. Stand and Play vs. Continuity vs. FMHS to SS2
brandonchinn178 commented 10 years ago

@noahsark769 So I noticed that the movement types in the viewer are mostly even or mark, even if it's FMHS instead of Even step. Furthermore, I don't know how we would be able to detect differences in "general movements" since its just a list of movements to the app. Should I just do 

GO  4N
    8E
MT 16E

kinda thing (where we can do even step as saying "GO 4N, 4E" to go diagonal NE) or something else?

I think the big thing for this issue is to figure out for every movement type what we should write. (Move, Stand, Mark Time, Goto, Arc, Even)

noahsark769 commented 10 years ago

Yeah, that's a problem I was thinking of too. Technically everything should be the correct step type (e.g. "even" vs "mark") in the viewer file (@kmdurand should we open an issue on calchart for that?), I think just "move", "mt" and "close" are the general actions we need to worry about.

Or well, I guess you're right, there are a few more. I would suggest (with examples of doing the action 16E):

  1. Move: Move 16E
  2. Stand: Close 16E
  3. Mark: MT 16E
  4. Goto: SEE ABOVE (16E) (The above part would say something like "Run to the sidelines and get ready for the dance block" etc)
  5. Arc: GT 16E CCW with radius 4 (not sure about this one)
  6. Even: Even 16E 12 steps

What do you think?

brandonchinn178 commented 10 years ago

It seems mostly god. For Goto, would it refer to a Dot Continuity? Could I say See Continuity (16 beats)? I feel like "16E" has no meaning when you're doing a continuity.

Also, for Even, if it's even step diagonal or something, it should be Even 16E, 4S (12 steps), for example, right (If they were moving evenly towards a dot 16 steps E and 4 steps S)?

Lastly, we're not going to put "Mini Military" or anything like that, right? They're just gonna have to write that on their own? The only way I can see us including that is by parsing the continuity text and seeing if "MM" shows up.

noahsark769 commented 10 years ago
  1. Good idea!
  2. Good idea! (Make sure we can account for Even 16E, 0.5S (12 steps) etc
  3. Nope, we might be able to implement step style later but not right now.
brandonchinn178 commented 10 years ago

For even step, I made it so if you have decimal movements, it just says "SE", because for the heart continuity, we got text saying Even 3.0875E, .01378S (4 steps) kind of thing, which is kind of extraneous, when people usually are just "It's that direction, and I'll remember how far away".

Also, the last stuntsheets of most songs contains continuities like "MT 2E", which I'm guessing is for Calchart Viewer's sake. Can we fix it so it's a "Stand" instead, so it'll read as "Close"? Along the same lines of "Even"/"Move"

noahsark769 commented 10 years ago
  1. Hm, I'm actually not sure about the first one: saying SE might make people think that they should go directly southeast, which is not usually the case. I see your point though, so let's leave it in for now and we can fix it later if need be (this won't even be remotely a problem in most cases).
  2. I'm actually not sure why that's there: @kmdurand do you know?
noahsark769 commented 10 years ago

Done in #118