PDF and dot continuity

[noahsark769]

Resolving #102 and #103 @brandonchinn178 alright here it is! Gunna go through and comment, then we can talk about the style changes!

[noahsark769]

ALRIGHT LET'S STYLE CHECK THIS

[noahsark769]

Okay @brandonchinn178 I made a lot of comments! Most are just changes that I think we should make to make the code as semantically clear as possible.

As far at the pdf goes, it's looking pretty good! I actually agree with you that I don't think we need the header at the bottom, and having it only at the top will improve the ability of people to naturally orient the pages.

Two things:

1. I think the general continuity box should collapse/expand to fit the continuity text inside it: for example, if I only FMHS 8W on a stuntsheet, there shouldn't be a lot of whitespace in that box. Of course, the box should expand also, up to a limit, at which point we should try to make the text smaller to fit it inside.
2. Since the last stuntsheet doesn't have any continuity, we don't need a continuity box.

Let me know what your thoughts are on this stuff!

[brandonchinn178]

At least on the continuity box, I think it's better to leave it constant sized (although smaller size when it overflows) so that the format of the quadrant stays the same through every box, which I think is a lot easier on the eyes. Thoughts?

[brandonchinn178]

Also, can we have stuntsheets go in NW, NE, SW, SE order? I feel like the last page is awkward with two stuntsheets on the left side, and I feel like people would be more naturally inclined to look left to right instead of top to down

[noahsark769]

Yeah I think you're right about the continuity box: I think everything should be laid out the same way, but I just think that the box shouldn't take up the whole height if it doesn't need to (but if it does, it should, and also make the text smaller if it needs more space). Like, the elements right under the box would still be positioned as if the box was at max height, but it seems weird to have a big empty space in the box.

Also, I think the point with having the stuntsheets oriented the way they currently are is so the marcher can fold the page over hotdog-style and see the stuntsheets in the right order without having to turn the page over: no one seems to fold their sheets hamburger-style right now, and though I think this should be a toggleable preference eventually, we wanted to start with the NW, SW, NE, SE order right?

[brandonchinn178]

Oh right, I forgot about that folding thing. Although you won't think that people would unfold it anyway when taking it out? I feel like most people would just naturally taking it out and unfold it right away.

I think the extra space in the box looks fine, but I'll push those changes and we can see then.

[brandonchinn178]

@noahsark769 what do you think about these changes?

[noahsark769]

I think we should call the various functions that generate the parts of the pdf page something more semantic (e.g. this._applyHeaders() instead of this._headers()). After that I think we're good for this!

[brandonchinn178]

@noahsark769 ready to merge!

[noahsark769]

Sweet, merging! The easy part is now done, haha