calband / calchart-viewer

An online show viewer and continuity generator for Calchart.
calband.github.io/calchart-viewer/
2 stars 2 forks source link

Movement Diagram #127

Closed brandonchinn178 closed 10 years ago

brandonchinn178 commented 10 years ago

Regarding #105 Lol here's my initial implementation @noahsark769. I didn't do number of steps per path because 1. it's in the individual continuity and 2. it looks gross. What do you think?

brandonchinn178 commented 10 years ago

Oh wait I forgot to implement arc... hold on @noahsark769 how exact do you want the arc lines? its apparently really hard to get exact circular arcs with cubic bezier curves

brandonchinn178 commented 10 years ago

So I implemented the arc movements, but it looks a bit janky... what do you think? A good example is F3 for boy band

noahsark769 commented 10 years ago

Hmmm yeah the arcs look pretty jank: maybe another option would be to draw the preview to a <canvas> then export as image data to draw to the pdf? Otherwise, it looks like you can approximate a circle using bezier like Chrome does

noahsark769 commented 10 years ago

(Also, you could technically draw the arc as part of the sides of a many sided polygon instead of a circle: this had the added benefit (or maybe non-benifit?) that we could have the number of sides of the polygon correlate to the number of steps it would take to move around 360 degrees - then you're actually mapping out the steps instead of the curve. Up to you which method to use

noahsark769 commented 10 years ago

Also, could we draw the yardline number smaller? I feel like they can be at least as small as the continuity numbers, if not smaller: as long as you can see them, the size isn't very important

brandonchinn178 commented 10 years ago

Well we're mapping arcs, not circles, so that stack overflow isn't too helpful...?

brandonchinn178 commented 10 years ago

@noahsark769 I made it into a many-sided polygon. It looks a lot better and turned out to be pretty easy! Thanks!

noahsark769 commented 10 years ago

Sweet, I think this is good to go then! Great job!