Clean up code?

[brandonchinn178]

Possibly clean up PDF Generator code. Specifically, try to make box objects less complicated and extract the draw function into the actual function. Box objects should only know about themselves, we don't need to make them worry about drawing movements or continuities or anything. KEEP MODULAR

[noahsark769]

You read my mind

[brandonchinn178]

We can also release the PDF Generator without cleaning up code. We'll clean up while people test the PDFs

[brandonchinn178]

@noahsark769 Have any comments on how to clean up code? Obviously, as the writer, I think the style is fine for the code, but the code is not clean... Started it a bit on the branch pdf__clean_up

[noahsark769]

Hm, possibly I might think of extracting the drawing code for each widget (ic, imd, bev, sd) into a real class in its own file, that way you could extract some functionality into a base class (for example, have a PDFWidget class and a IndividualContinuityWidget and BirdsEyeViewWidget that extends it, and both would have a draw() method). That would make it cleaner for adding options as well.

Other than that, I bet you could write some utility functions for PDF drawing. I can do a thorough review of the code later and offer suggestions as well On Mon, Nov 24, 2014 at 5:20 PM Brandon Chinn notifications@github.com wrote:

@noahsark769 https://github.com/noahsark769 Have any comments on how to clean up code? Obviously, as the writer, I think the style is fine for the code, but the code is not clean... Started it a bit on the branch pdf__clean_up

— Reply to this email directly or view it on GitHub https://github.com/calband/calchart-viewer/issues/131#issuecomment-64295344 .

[brandonchinn178]

@noahsark769 Can you see what I've done with the IndividualContinuityWidget class? Something like that?

[noahsark769]

Yeah I like that! I would definitely add more description in the comments about what a widget is in general and how it should function, but the pattern looks very good