calband / calchart-viewer

An online show viewer and continuity generator for Calchart.
calband.github.io/calchart-viewer/
2 stars 2 forks source link

Possible Fix To Safari Ogg Issue #145

Closed kmdurand closed 9 years ago

kmdurand commented 9 years ago

Possible fix to #112 Even if it doesn't fix that particular issue, it is a fix to the way that soundmanager is setup.

noahsark769 commented 9 years ago

Hm @kmdurand are you able to upload .ogg files to safari on your machine? I'm still getting the "Please upload a valid audio file". Also, I was looking in the soundmanager documentation and found this:

SM2 uses Flash's native Sound object for loading and managing sound, so it is subject to the same limitations that Flash 8 is. Perhaps a design decision, the Flash 8 sound object only supports MP3 files through the loadSound() ActionScript method. SM2 is not able to load other sound formats, including audio-only SWF files, due to this limitation. Refer to the Flash 8 documentation for details.

Perhaps it's impossible

kmdurand commented 9 years ago

Yeah you're right -- I just assumed that flash would be able to play ogg but after looking into it a little bit it seems like it can't. I'm sure there are ways around this, but I don't think they're really worth the time, especially since we could just start distributing wav files for people using safari.

noahsark769 commented 9 years ago

I agree. I'm gunna merge this pull request for the soundmanager configuration fix anyway, because it's still useful since it allows browsers that don't support mp3 to play mp3. Then we can close the issue as a wontfix.