search

calband / calchart-viewer

An online show viewer and continuity generator for Calchart.
calband.github.io/calchart-viewer/
2 stars 2 forks source link

Dots clickable #155

Closed brandonchinn178 closed 9 years ago

brandonchinn178 commented 9 years ago

Resolves #151

brandonchinn178 commented 9 years ago

I specified it so that it only selects options from that select box. Also, the [value=] box refers to the

noahsark769 commented 9 years ago

Right, but I was thinking that we shouldn't make it dependent on the value.

This would mean that, if we wanted to change the values (for example, maybe we might want to specify a specific dot in some other way than dot label: we would change the value attributes in this case) then we would have to worry about the click functionality implemented here breaking also, right? Which is why I think we should put the data-dot-label="A1" or js-dot-label="A1" in addition to value="A1"

brandonchinn178 commented 9 years ago

Ok, wasn't sure if you meant that. Fixed it!

Also, because there's a pink circle around the selected dot, you can't select the dots right next to the currently selected dot...

noahsark769 commented 9 years ago

I think not being able to click on the dots directly adjacent is fine for now: if people really want to do that, then they can just deselect the dot, haha. Gunna merge this, it looks good, thanks!