search

calband / calchart-viewer

An online show viewer and continuity generator for Calchart.
calband.github.io/calchart-viewer/
2 stars 2 forks source link

Fix bug in recalculating steps #157

Closed brandonchinn178 closed 9 years ago

brandonchinn178 commented 9 years ago

@noahsark769 Quick and easy bug fix

noahsark769 commented 9 years ago

It's not immediately apparent to me what the bug is. What was the problem...doesn't this do the same thing?

brandonchinn178 commented 9 years ago

No, before, if the coordinate was 7 steps from the south yardline, it would recalculate as 7-4=3 steps from the north sideline, when it should really be 8-7=1 steps away

noahsark769 commented 9 years ago

Oh I see, you're right! Good catch! I think this is good to go then. We should really get some unit tests going for this type of thing.

brandonchinn178 commented 9 years ago

lol too lazy

noahsark769 commented 9 years ago

haha I'll try to put in cocoa/karma for testing at some point

noahsark769 commented 9 years ago

ohhhhh and travis so tests run every time you push