search

calband / calchart-viewer

An online show viewer and continuity generator for Calchart.
calband.github.io/calchart-viewer/
2 stars 2 forks source link

PDF Options #159

Closed brandonchinn178 closed 9 years ago

brandonchinn178 commented 9 years ago

Resolves #131 #142 #152 #153 #154 @noahsark769 I think this is pretty functional! What do you think?

noahsark769 commented 9 years ago

Holy crap I'm excited about this. I'll review it maybe tonight. Can you post a screenshot of the options UI?

brandonchinn178 commented 9 years ago

screen shot 2014-12-07 at 4 26 15 pm This is it currently!

noahsark769 commented 9 years ago

Cool! Can you:

  1. Add padding to the html part of the UI
  2. Add margin below the gold divider line: it looks cramped now
  3. Line up the left edge of the leftmost option box with the start of the text

I think tightening up the UI with those changes will make it look a little more friendly :)

brandonchinn178 commented 9 years ago

screen shot 2014-12-08 at 1 41 40 am Here's the new UI! The options also become scrollable if the window gets too skinny

noahsark769 commented 9 years ago

Woohoo, a few more things:

  1. Let's change the IMD (individual movement diagram) orientation and the SD (surrounding dots) orientation to be east up by default.
  2. I think we can take out the surrounding dots option for the end sheet: it's very small so you can't really read the numbers, and I think that it won't be terribly useful.
  3. I think we can just take out the "Choose your options" header entirely: it's pretty obvious that those are the options since they're radio buttons, and that will make more room for the pdf also.
  4. Can we make the options bar + the iframe take up exactly 100% of the page? When it's longer than the page height, you sometimes can't make the option to print pop up (at least in Chrome).
  5. I think it would look nice if the Layout Order options box were the same height as the others: screen shot 2014-12-12 at 11 24 49 am

This is super awesome though! I'm gunna go through and do code comments also

noahsark769 commented 9 years ago

Alright a few things to take care of but it looks good! Taking a 1200 line fine and breaking it up into manageable components is always a good thing!

brandonchinn178 commented 9 years ago

For the Endsheet Widget > Surrounding Dots, surrounding dots was what Divina specifically asked for to accompany the endsheet, so... idk

Also, can we use this? http://caniuse.com/#feat=calc it's experimental, but it seems pretty compatible

noahsark769 commented 9 years ago

Lol well, alright, I guess if somebody wants it. I think using calc is fine!

noahsark769 commented 9 years ago

Sweet! We can take out PDFGenerator._addHeaders now because that's done with the HeaderWidget, right?

noahsark769 commented 9 years ago

Awwww yeaaah, let's merge!