search

calc-project / grouping-sounds

Datand Code Accompanying the Study "Grouping Sounds into Evolving Units for the Purpose of Historical Language Comparison"
MIT License
0 stars 0 forks source link

input() kills grouping.py #1

Closed FredericBlum closed 8 months ago

FredericBlum commented 8 months ago

I just tried to replicate the code presented in grouping.py, and the code dies at line 86 (https://github.com/calc-project/grouping-sounds/blob/main/grouping.py#L86), when calling input(). Removing the line solves this problem. But do we lose some functionality here?

LinguList commented 8 months ago

In my tests with the data, nothing died, because the data have no errors. If there are errors, input allows to check them step by step. There should not be an error. Did you encounter an error here, or only that the code just finishes and prints out problems?

LinguList commented 8 months ago

The code is actually in such a form that I should update it immediately on Zenodo, for the paper we submitted. Well, the proof-of-concept, that we can convert there and back is there, but the input() line is ugly, and was just for debugging and checking.

FredericBlum commented 8 months ago

Running the code as is in the repository, I DO receive an error:

l̥.w i.t̚ ⁵⁵ «<l>» «̥» «<_>» «<w>» «<_>» «<i>» «<_>» «<t>» «̚» «<_>» «⁵» «⁵»

Which is why the code does not finalize for me.

LinguList commented 8 months ago

The code finalizes if you press ENTER.

LinguList commented 8 months ago

The error annoys me, I also get it now.

LinguList commented 8 months ago

But now, that I modified the profile, the error disappears.

LinguList commented 8 months ago

I modified it by running make-profile.py

FredericBlum commented 8 months ago

Thanks, this is solved now.