Closed runer112 closed 3 months ago
Personally, I'd prefer there not to be a strict dependence on git (either being installed or the repo having been cloned, e.g. it could have been downloaded as a .zip or .tar.gz). I'd probably want it to be handled as a fallback version string (probably at the top of tiboyce.asm) if it's not specified on the command-line, which also makes it more easily buildable without using the build script.
@calc84maniac:
Personally, I'd prefer there not to be a strict dependence on git (either being installed or the repo having been cloned, e.g. it could have been downloaded as a .zip or .tar.gz). I'd probably want it to be handled as a fallback version string (probably at the top of tiboyce.asm) if it's not specified on the command-line, which also makes it more easily buildable without using the build script.
This should all be addressed. See the updated contents of the first comment demonstrating the PR's changes.
It's looking pretty good now, and I've got a few more improvements implemented locally that I'll commit after merge (mainly fixing a false positive in the "not run from cmd" detection, but I also decided to remove some of the more useless echos and make the lst/lab files optional now that additional parameters are passed through to spasm)
Output of
build.bat
at daf0ec6ce49ead5057ad895b016eef46527f7e43:Output of
build.sh
at b2e5aec14adaf36ca06e4202ccd877bdc62c1654:Screenshot of the main TI-Boy CE settings page at daf0ec6ce49ead5057ad895b016eef46527f7e43:
Screenshot of the main TI-Boy CE settings page at daf0ec6ce49ead5057ad895b016eef46527f7e43 with a dirty working tree:
Screenshot of the main TI-Boy CE settings page at daf0ec6ce49ead5057ad895b016eef46527f7e43 tagged as "v0.3.1":
Screenshot of the main TI-Boy CE settings page at daf0ec6ce49ead5057ad895b016eef46527f7e43 tagged as "v0.3.1" with a dirty working tree:
Screenshot of the main TI-Boy CE settings page at daf0ec6ce49ead5057ad895b016eef46527f7e43 with
git describe
failure:Screenshot of the main TI-Boy CE settings page at daf0ec6ce49ead5057ad895b016eef46527f7e43 built with
build "-DVERSION=\"cool version\""
or./build.sh '-DVERSION="cool version"'
: