search

calcinai / xero-php

A php library for the Xero API, with a cleaner OAuth interface and ORM-like abstraction.
MIT License
359 stars 262 forks source link

payrollau Employees:EligibleToReceiveLeaveLoading should be true and not string #835

Open ValentinNikolaev opened 2 years ago

ValentinNikolaev commented 2 years ago

According to documentation https://developer.xero.com/documentation/api/payrollau/employees/

image

https://github.com/calcinai/xero-php/blob/master/src/XeroPHP/Models/PayrollAU/Employee/TaxDeclaration.php#L188

ValentinNikolaev commented 2 years ago

Its ok when we push 'string' "false" or "true" but should be bool. I have major issues relate to this type casting

calcinai commented 2 years ago

@ValentinNikolaev happy to accept a PR correcting this type in the model.