calcinai / xero-php

A php library for the Xero API, with a cleaner OAuth interface and ORM-like abstraction.
MIT License
359 stars 262 forks source link

Added support for MergedToContactID. #900

Closed JackGreen411 closed 1 year ago

JackGreen411 commented 1 year ago

The Scenario

Whenever a contact has been merged into another, we received a webhook event of an archived contact, but no additional information. We then had to perform a GET request by its 'resourceId' to get the contact.

The 'Before the addition of MergedToContactID:' screenshot below, show the payload we received when we made the GET request, but no 'MergedToContactID' was present.

The important aspect of this PR, is ensuring we received the 'MergedToContactID' value, allowing us to update our contact data with the newly updated ContactID.

Before the addition of MergedToContactID:

image

After the addition of MergedToContactID:

image
elliotlings commented 1 year ago

Bump. It would be good if MergedToContactID was returned with a Contact which it currently isn't.

calcinai commented 1 year ago

LGTM, thanks