search

calcom / docker

The Docker configuration for Cal.com is an effort powered by people within the community. Cal.com, Inc. does not provide official support for Docker, but we will accept fixes and documentation. Use at your own risk.
MIT License
646 stars 338 forks source link

Fix shellcheck issues #258

Closed jokay closed 1 year ago

jokay commented 1 year ago

Fixes the shellcheck issues SC2148, SC2086 and SC2162.

In /github/workspace/scripts/replace-placeholder.sh line 1:
FROM=$1
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.

In /github/workspace/scripts/replace-placeholder.sh line 14:
while read file; do
      ^--^ SC2162 (info): read without -r will mangle backslashes.

In /github/workspace/scripts/start.sh line 8:
scripts/wait-for-it.sh ${DATABASE_HOST} -- echo "database is up"
                       ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
scripts/wait-for-it.sh "${DATABASE_HOST}" -- echo "database is up"

For more information:
  https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs...