Closed alishaz-polymath closed 11 months ago
Happy to review! I see you're still pushing some things. Give me a heads up when it's ready
Happy to review! I see you're still pushing some things. Give me a heads up when it's ready
Hey, Yeah. Still working through. I'll ping once it's ready for your review 🙌
@alishaz-polymath one quick thought, for convenience you could create another docker-compose.yml (maybe in a /test folder? a docker-compose.test.yaml maybe), which provides a different command
for the calcom container to run, and effectively run unit tests or integration tests instead of the standard start script.
https://docs.docker.com/compose/multiple-compose-files/extends/
@krumware Thank you, I'll give it a go tomorrow, pretty late here 😅
Hey @krumware Can you please review? I think we can revisit the suggestion you left earlier for maybe next week (I will take it up next week), but if you could review the rest, it would be super awesome 🙌
Oh nice catch indeed! I'll take it up tomorrow morning 🙏
@krumware Gentle nudge for review 🙏
Sorry for delay, travelling. Looks good, comments included can be addressed in the future. Thanks!
This PR attempts to add a runtime check as well as runtime logs and build logs to the
docker-build-push-dockerhub.yml
workflow