calcom / docker

The Docker configuration for Cal.com is an effort powered by people within the community. Cal.com, Inc. does not provide official support for Docker, but we will accept fixes and documentation. Use at your own risk.
MIT License
646 stars 338 forks source link

Add runtime check, runtime logs and build logs #293

Closed alishaz-polymath closed 11 months ago

alishaz-polymath commented 11 months ago

This PR attempts to add a runtime check as well as runtime logs and build logs to the docker-build-push-dockerhub.yml workflow

krumware commented 11 months ago

Happy to review! I see you're still pushing some things. Give me a heads up when it's ready

alishaz-polymath commented 11 months ago

Happy to review! I see you're still pushing some things. Give me a heads up when it's ready

Hey, Yeah. Still working through. I'll ping once it's ready for your review 🙌

krumware commented 11 months ago

@alishaz-polymath one quick thought, for convenience you could create another docker-compose.yml (maybe in a /test folder? a docker-compose.test.yaml maybe), which provides a different command for the calcom container to run, and effectively run unit tests or integration tests instead of the standard start script. https://docs.docker.com/compose/multiple-compose-files/extends/

alishaz-polymath commented 11 months ago

@krumware Thank you, I'll give it a go tomorrow, pretty late here 😅

alishaz-polymath commented 11 months ago

Hey @krumware Can you please review? I think we can revisit the suggestion you left earlier for maybe next week (I will take it up next week), but if you could review the rest, it would be super awesome 🙌

alishaz-polymath commented 11 months ago

Oh nice catch indeed! I'll take it up tomorrow morning 🙏

alishaz-polymath commented 11 months ago

For added context: I've tested this with v3.2.8 and runtime test fails (as expected), but goes through fine with v3.0.0 (as expected). 🙏

alishaz-polymath commented 11 months ago

@krumware Gentle nudge for review 🙏

krumware commented 11 months ago

Sorry for delay, travelling. Looks good, comments included can be addressed in the future. Thanks!