calcom / synclinear.com

End-to-end sync of Linear and GitHub.
https://synclinear.com
MIT License
372 stars 61 forks source link

Adding "linear" tag doesn't sync issue from GitHub to Linear #118

Closed jonathimer closed 1 year ago

jonathimer commented 1 year ago

Expected behavior: When adding the linear tag, GitHub issues that are not in Linear yet, should be synced to Linear.

This currently doesn't work for. I also tried to connect everything via https://synclinear.com/.

See example: https://github.com/CrowdDotDev/crowd.dev/issues/1169

tedspare commented 1 year ago

Thanks @jonathimer - could you try signing into GitHub on SyncLinear.com, removing the sync (if visible), then re-syncing? Let me know if this doesn't fix it.

jonathimer commented 1 year ago

I just did the re-sync and also removed/added the tag again. It's still not working.

tedspare commented 1 year ago

Thanks, Jon. It seems there's an issue with GH label events affecting a few areas. Looking into it.

tedspare commented 1 year ago

Hey again @jonathimer. We made some updates to the GH label listener - is the issue still happening?

jonathimer commented 1 year ago

Thanks for getting back. Unfortunately, its still not solved for me.

Adding the "linear" tag to any issue doesn't do anything. I also tried to re-connect the whole integration again.

kautukkundan commented 1 year ago

For us it doesn't sync when someone else (one who hasn't deployed the webhook) from the contributor list opens an issue and tags it with "linear" is there any workaround for that?

tedspare commented 1 year ago

@kautukkundan unfortunately not, intentionally. This is to prevent bad actors from affecting a private Linear team through this tool.

nikitnikoks commented 1 year ago

@tedspare was the issue resolved? It doesn't work for me either. I use different emails for Linear and Github, but I authorized both apps, so the webhook should be added.

Jstein77 commented 1 year ago

@tedspare I'm hitting the same thing! Thanks for looking into this, this project is awesome.

tedspare commented 1 year ago

Not yet @nikitnikoks and thanks @Jstein77! Looking into it right now. A few others have reported this offline so I think the webhook structure changed.

Edit: pushed a potential fix - is the issue still happening?

Jstein77 commented 1 year ago

@tedspare no dice. I tried redeploying the webhook, and tagging and issue in github with linear but did not see it sync to my linear project.

haroldao commented 1 year ago

Same issue here 👀

tedspare commented 1 year ago

Sorry about that! In your repo > Settings > Webhooks > SyncLinear.com > Recent Deliveries > 1 > Response, do you see an error message related to the GitHub token?

haroldao commented 1 year ago

Nothing

joanagmaia commented 1 year ago

Sorry about that! In your repo > Settings > Webhooks > SyncLinear.com > Recent Deliveries > 1 > Response, do you see an error message related to the GitHub token?

Hey @tedspare I get the same issue, and in Webhooks log I get this message: {"success":false,"message":"GitHub webhook secret doesn't match up."} Error code: 403

tedspare commented 1 year ago

Thanks @joanagmaia. It seems webhook secrets are expiring and not refreshing (I see no docs on this). Thinking of a secure way to refresh them when this error comes up. In the meantime, feel free to get in touch and we can roll it manually.

image

joanagmaia commented 1 year ago

@tedspare at the moment, we are getting this error for all deliveries And the sync is not working for any of us, neither from github or to github

What would be the fix for this? To update the secret as you have on your screen?

tedspare commented 1 year ago

Yep, reach out to me and we'll update it in the DB! (Temp solution)

ArctypeZach commented 1 year ago

~Trying to evaluate this tool as a solution for our org and running into the same issue— Linear -> GH works just fine, but tagging GH issues fails to sync them. Re-syncing does not appear to have any effect~

Update: didn't have sufficient perms to deploy the GH webhook. Actually works out of the box once perms are correctly configured!

tedspare commented 1 year ago

Closing as resolved, thanks @joanagmaia @ArctypeZach!

Jstein77 commented 1 year ago

Hey @tedspare i'm seeing the same error message {"success": false,"message":"GitHub webhook secret doesn't match up."}

Can I get your help updating the secret?