caldo43 / naclports

Automatically exported from code.google.com/p/naclports
0 stars 0 forks source link

Fake ld script hides real ld return code #8

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi.

So this fake ld script has a problem: the generated shell script that runs the 
real application and greps out the stderr messages causes this to return 1 
instead of the binary's exit code in some circumstances.
When configure runs, it's checking the error code and because it gets a failure 
code, won't continue.

Dave

Original issue reported on code.google.com by krasin@google.com on 9 Sep 2010 at 12:11

GoogleCodeExporter commented 8 years ago
The proposed fix is http://codereview.chromium.org/3320014

Original comment by krasin@google.com on 9 Sep 2010 at 12:12

GoogleCodeExporter commented 8 years ago
Committed as http://code.google.com/p/naclports/source/detail?r=107

Original comment by krasin@google.com on 9 Sep 2010 at 12:17

GoogleCodeExporter commented 8 years ago
I tried this, but it didn't work.  I go tthis error message:

./a.out: line 2: return: can only `return' from a function or sourced script

Original comment by d...@google.com on 9 Sep 2010 at 3:20

GoogleCodeExporter commented 8 years ago
Latest version of this code that I tested:
http://code.google.com/p/naclports/source/detail?spec=svn109&r=109

is working as corrected.  I have verified it.

Original comment by d...@google.com on 14 Sep 2010 at 5:03

GoogleCodeExporter commented 8 years ago

Original comment by krasin@google.com on 14 Sep 2010 at 5:52