caldwell / build-emacs

Build scripts for www.emacsformacosx.com
http://www.emacsformacosx.com/about
GNU General Public License v3.0
364 stars 61 forks source link

decompress man page files #105

Closed xxyzz closed 3 years ago

xxyzz commented 3 years ago

Emacs's Makefile compresses the man pages but Homebrew only supports the decompressed man page file. This pull request decompress these files for Homebrew or other package managers to install manuals.

There are some argument errors about FileUtils functions in verbose-shell.rb on Ruby 3.0.0 but I'm not sure whether my fixes are suitable(remove options argument) so I don't include those commits here.

I also added GitHub action to build Emacs in my forked repo, I can send another pull request if you want it.

caldwell commented 3 years ago

Thanks (especially for the nice links!), but to me this sounds like a bug in brew. gzipped man pages are perfectly legit:

$ man /Applications/Emacs.app/Contents/Resources/man/man1/ebrowse.1.gz

It seems like the more correct fix would be to fix their RE:

        section = source.to_s[/\.([1-8]|n|l)(?:\.gz)?$/, 1]
xxyzz commented 3 years ago

I don't even know man supports .gz before, I should check man man first... Thanks for the information.