search

caldwell / build-emacs

Build scripts for www.emacsformacosx.com
http://www.emacsformacosx.com/about
GNU General Public License v3.0
364 stars 61 forks source link

Add support for apple notarization #112

Closed directionless closed 1 year ago

directionless commented 2 years ago

An attempt at adding apple notarization to the build process. This can be done with any developer account so whatever account is being used to sign this should be able to do this. But, you may need to create a "app-specific-password". I'm not really sure how the callers or secrets management works here, so I left those parts blank. For background, Apple has some docs up for this at https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/customizing_the_notarization_workflow

First, I needed to update the arguments to codesign. With this change I was able to notarize the resultant binary

Second, it needs to be submitted to Apple for notarization. I can't really test this ruby, I don't have this build chain installed. But those are the commands I use in my projects, and I tried to fit them into the style used here.

Fixes #109 Fixes #99

caldwell commented 1 year ago

I took this as the basis and tweaked it a bit when I implemented notarization back in 1c5c1174a67410b5beacd60e52dfdf452e422370. When I made the commit message I forgot to reference this PR. Thanks for making it btw—it was what prodded me into finally starting the notarization stuff (even though it took me another couple months 🙂). I hadn't been aware of the CLI tools involved so just seeing the names of them was super helpful.

directionless commented 1 year ago

I'm glad it could help!