search

caldwell / build-emacs

Build scripts for www.emacsformacosx.com
http://www.emacsformacosx.com/about
GNU General Public License v3.0
364 stars 61 forks source link

Keep up with Homebrew deprecation #96

Closed marcbowes closed 4 years ago

marcbowes commented 4 years ago

In https://github.com/Homebrew/brew/commit/4f75a77b089e65ff9e03c65d192808aa4ea6842f, a method was removed.

It seems Formulary.find_with_priority is now deprecated. In the Homebrew commit, they replaced callsites to use .factory instead. So I did that here. Seems to work locally.

The reason for this change is I updated Homebrew and then tried to rebuild Emacs with jansson; it failed with:

Error: undefined method `find_with_priority' for Formulary:Module
.../build-emacs/brew/bin/brew-source.rb:30:in `block in <top (required)>'
caldwell commented 4 years ago

Whoops, I also ran into this back in May but forgot to push to github. Thanks for the patch and I'm sorry to make you debug this!