search

caldwell / renderjson

Render JSON into collapsible HTML
http://caldwell.github.io/renderjson
418 stars 91 forks source link

Allowing syntactic quotess to be removed or overriden #6

Closed raadad closed 9 years ago

raadad commented 9 years ago

I have a requirment to make JSON more human readable, to do this i needed to remove the syntatic quotes from being rendered, I have tried to do this in as unobtrusive way as possible

caldwell commented 9 years ago

Hi, thanks for your pull request.

I'm not sure I like this technique of making the quotes configurable, because it is a very narrow use case. I think the way to go here would be to make the quotes have their own CSS syntax class, like {, }, [, and ]. Then you could remove them and other people could style them in completely different ways. Overall it just seems like a better direction to go.

Would you be up for implementing that, instead?

raadad commented 9 years ago

You make a good point, the required change will be minimal so when I find time ill push another commit through