search

caleb531 / automata

A Python library for simulating finite automata, pushdown automata, and Turing machines
https://caleb531.github.io/automata/
MIT License
339 stars 64 forks source link

Simplified binary operations for DFAs #139

Closed EduardoGoulart1 closed 1 year ago

EduardoGoulart1 commented 1 year ago

This is the PR. Hope it is good to go now

coveralls commented 1 year ago

Coverage Status

Coverage: 100.0%. Remained the same when pulling da0c141c191f48f05512c9f657012942af62ee57 on EduardoGoulart1:simplify-binary-operations into e8605ad36e0e180f453588a13dae039d3e68ce53 on caleb531:develop.

EduardoGoulart1 commented 1 year ago

See https://github.com/caleb531/automata/pull/133 for past discussion

eliotwrobson commented 1 year ago

I haven't had time to do a full review, but everything here looks really good (+1 for accurate type hints everywhere) and cleaner than the previous code. None of the test cases or parts of the public interface are modified, so I'm inclined to say this should be merged soon.

caleb531 commented 1 year ago

I've resolved the remaining conversation threads by just committing those small tweaks myself. @EduardoGoulart1 did you have any other changes you wanted to make to this PR before I perform a final review / merge?

cc @eliotwrobson

EduardoGoulart1 commented 1 year ago

I've resolved the remaining conversation threads by just committing those small tweaks myself. @EduardoGoulart1 did you have any other changes you wanted to make to this PR before I perform a final review / merge?

cc @eliotwrobson

No... Go ahead!