search

caleb531 / automata

A Python library for simulating finite automata, pushdown automata, and Turing machines
https://caleb531.github.io/automata/
MIT License
348 stars 64 forks source link

Use official Flake8 VS Code extension #203

Closed caleb531 closed 9 months ago

caleb531 commented 9 months ago

@eliotwrobson Just a small quality-of-life improvement, but with a small caveat, and so want your feedback.

This commit switches the third-party cornflakes-linter VS Code extension to the official Flake8 extension by Microsoft. I'm hoping this should fix an issue I've encountered with the former extension where files within the virtualenv or within Python stdlib were linted when they should have been ignored. I haven't tested that the new extension fixes this, but given that it's first-party, I'm optimistic that it's less buggy.

The catch with this change is that anyone who has installed the official Flake8 extension should uninstall cornflakes-linter (or disable it for the workspace) lest they see duplicate errors in the Problems panel (or otherwise experience other unforeseen conflicts between the extensions).

coveralls commented 9 months ago

Coverage Status

coverage: 99.64%. remained the same when pulling ebe48dcecc0c1f72bb0a33279787e8f0c3e81629 on flake8-official into 13e5c1b5bf1d92522eb83e914ad946552b77aaf7 on develop.

caleb531 commented 9 months ago

@eliotwrobson That's a good point. Especially since the recommendations are just that—they're not required or forced on VS Code users, and can be easily dismissed. With that, I think I'm going to proceed to merge this—thank you for your input!