basic addLayer test stopped working

dksmiffs commented 12 years ago

Caleb,

The following code is almost identical to the first example under the "Adding Layers" doc. This code works in 5b69e28782 (6/12/2012 5:53p) but doesn't draw a rectangle at all in 02da01c8f3 (6/12/2012 6:11p). I tried backing out a few individual changes from this latest rev, but wasn't able to pinpoint the line of code causing this change. Any ideas?

~ Dave

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="utf-8">
  <title>jCanvas trivial addLayer, drawRect demo</title>
  <style>
    html, body { width:100%; height:100%; margin: 0px;}
    canvas { display:block; }
  </style>
</head>
<body>
  <div id="content">
    <canvas id="bg"></canvas>
  </div>
  <script src="public/resources/jquery/jquery-1.7.2.min.js"></script>
  <script src="public/resources/jcanvas/jcanvas.min.js"></script>
  <script>
    $(document).ready(function(){
      $("#bg").addLayer({method: "drawRect", fillStyle: "green", x: 10, y: 10,
                         width: 40, height: 95, fromCenter: false})
      .drawLayers();
    });
  </script>
</body>
</html>

caleb531 commented 12 years ago

Actually, make that quite a few lines.

Apparently, all of the internal addLayer function calls were removed out of the source (for each method that supports the layer property). Fortunately, I just pushed a new commit with the changes. I think I know what caused it, but that's a long story.

-Caleb

On Mon, Jun 18, 2012 at 11:24 AM, dksmiffs < reply@reply.github.com

wrote:

Caleb,

The following code is almost identical to the first example under the "Adding Layers" doc. This code works in 5b69e28782 (6/12/2012 5:53p) but doesn't draw a rectangle at all in 02da01c8f3 (6/12/2012 6:11p). I tried backing out a few individual changes from this latest rev, but wasn't able to pinpoint the line of code causing this change. Any ideas?

~ Dave
<!DOCTYPE html>
<html lang="en">
<head>
 <meta charset="utf-8">
 <title>jCanvas trivial addLayer, drawRect demo</title>
 <style>
   html, body { width:100%; height:100%; margin: 0px;}
   canvas { display:block; }
 </style>
</head>
<body>
 <div id="content">
   <canvas id="bg"></canvas>
 </div>
 <script src="public/resources/jquery/jquery-1.7.2.min.js"></script>
 <script src="public/resources/jcanvas/jcanvas.min.js"></script>
 <script>
   $(document).ready(function(){
     $("#bg").addLayer({method: "drawRect", fillStyle: "green", x: 10, y:
10,
                        width: 40, height: 95, fromCenter: false})
     .drawLayers();
   });
 </script>
</body>
</html>
Reply to this email directly or view it on GitHub: https://github.com/caleb531/jcanvas/issues/20

dksmiffs commented 12 years ago

Yes, I noticed you changed quite a few lines in that rev. What I meant was I tried backing out a few individual lines from that change in several tests I ran to see if I could figure out what was breaking me, to no avail. Yes, I noticed all of the internal addLayer function calls had been removed.

Okay - I'll retest with your new push when I get back to the office tomorrow. Thanks, ~Dave

dksmiffs commented 12 years ago

fccc07774c1c736a1af714fd30dfdcf6d292555c fixed it, thanks much for the quick turnaround.

caleb531 / jcanvas

basic addLayer test stopped working #20