search

caleb531 / jcanvas

A jQuery plugin that makes the HTML5 canvas easy to work with.
https://projects.calebevans.me/jcanvas/
MIT License
626 stars 192 forks source link

"Functions as Layers" issue #24

Closed dksmiffs closed 12 years ago

dksmiffs commented 12 years ago

Caleb - First, thanks for the drag-drop feature, that looks like a great addition. I wanted to let you know that between revisions 39dd4bdb759aa38547b7da4a95dae2540ce0aee9 (yesterday) and 996b3d1aaffdbd757d9f4f2c35e3833603328575 (today), some of my test code modeled after the first example code in your "Functions as Layers" docs (http://calebevans.me/projects/jcanvas/docs.php?p=layers) stopped working.

dksmiffs commented 12 years ago

Also, code that we first discussed back on Issue #16 has stopped working again (the alert no longer pops up at all) between the same two versions. Here's a shorter version of that code:

$(document).ready(function() {
  function test(outer) {
    $("canvas").addLayer(function(ctx) {
      alert("Demonstrating access to >>>" + outer + "<<< from inner fn.  This" +
            " works after Caleb's 2012-06-07 jCanvas update.");
    });
    $("canvas").drawLayers();
  }
  test("outerValue");
});
caleb531 commented 12 years ago

Could you please send me the test code you're using so I can confirm this issue?

-Caleb

On Fri, Jul 20, 2012 at 1:11 PM, dksmiffs < reply@reply.github.com

wrote:

Caleb - First, thanks for the drag-drop feature, that looks like a great addition. I wanted to let you know that between revisions 39dd4bdb759aa38547b7da4a95dae2540ce0aee9 (yesterday) and 996b3d1aaffdbd757d9f4f2c35e3833603328575 (today), some of my test code modeled after the first example code in your "Functions as Layers" docs ( http://calebevans.me/projects/jcanvas/docs.php?p=layers) stopped working.

Reply to this email directly or view it on GitHub: https://github.com/caleb531/jcanvas/issues/24

dksmiffs commented 12 years ago

The Sandbox code itself in your "Functions as Layers" docs doesn't seem to be working. It's even shorter than my test code:

$("canvas").addLayer(function(ctx) {
  ctx.fillStyle = "#36a";
  ctx.fillRect(50, 50, 100, 50);
})
.drawLayers();
dksmiffs commented 12 years ago

And sorry for putting two issues on this thread. I chose to do that because both issues are related to the "Functions as Layers" feature, so I was hoping they might be the same issue on your side.

caleb531 commented 12 years ago

Doesn't matter now; the latest commit fixes them. :P

-Caleb

On Fri, Jul 20, 2012 at 1:21 PM, dksmiffs < reply@reply.github.com

wrote:

And sorry for putting two issues on this thread. I chose to do that because both issues are related to the "Functions as Layers" feature, so I was hoping they might be the same issue on your side.

Reply to this email directly or view it on GitHub: https://github.com/caleb531/jcanvas/issues/24#issuecomment-7140283

dksmiffs commented 12 years ago

Looks great, thanks for the fast turnaround on the fix!