search

caleb531 / play-song

An Alfred workflow for quickly and easily playing music in the Apple Music app
MIT License
109 stars 9 forks source link

Use md5 hash instead of comparing and saving config.applescript #21

Closed tyilo closed 9 years ago

tyilo commented 9 years ago

As discussed in #20

tyilo commented 9 years ago

How about renaming compile-config.sh to compile-config and update-workflow.py to update-workflow?

caleb531 commented 9 years ago

I'd very much prefer to keep the extensions, because extensions are meaningful.

Caleb

tyilo commented 9 years ago

Fair enough.

I have added #!/bin/bash to the top of the script file. With this you can replace

do shell script "bash ./compile-config.sh"

with 

do shell script "./compile-config.sh"
caleb531 commented 9 years ago

I considered doing that, though I didn't want to worry about whether or not the file is set to be executable. I'm not certain that cloning a repository retains permissions in that way, though I would assume so. However, if you think this approach is entirely safe, go for it—the less code repeated throughout the codebase, the better.

Caleb

tyilo commented 9 years ago

Both git and zip (.alfredworkflow) stores permissions, so it shouldn't be a problem.

tyilo commented 9 years ago

Feel free to merge.

caleb531 commented 9 years ago

Looks good to me. Nice work.